Add stub for options interface #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jul 18, 2022
| @@ -0,0 +1,41 @@ | |||
| <?php | |||
|
|
|||
| namespace Symfony\Component\OptionsResolver; | |||
Member
There was a problem hiding this comment.
Needs to be registered in stubFiles in extension.neon.
Also since you're making Options class generic, you need to add it to parameters.featureToggles.skipCheckGenericClasses, similarly to here: https://github.com/phpstan/phpstan-src/blob/74228e6f930c9a0e6ca9461557a6d40b92cf4e91/conf/config.neon#L23-L33 (this list will be purged with the next major version).
Member
|
The failures are my bad, with strict-rules these problems are reported: https://phpstan.org/r/2fb146c6-12dc-4a17-bb28-e13d93e820ea |
Member
|
Reported: phpstan/phpstan#7652 |
rvanvelzen
reviewed
Jul 19, 2022
Co-authored-by: Richard van Velzen <rvanvelzen1@gmail.com>
ondrejmirtes
force-pushed
the
feature/options-stub
branch
from
c7138a9 to
6559254
Compare
ondrejmirtes
approved these changes
Jul 19, 2022
Member
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is correct. First time creating stubs.
Based on discussion in phpstan/phpstan#7650